window: reset timeout source id before setting property
authorCosimo Cecchi <cosimoc@gnome.org>
Tue, 2 Apr 2013 19:54:02 +0000 (15:54 -0400)
committerCosimo Cecchi <cosimoc@gnome.org>
Tue, 2 Apr 2013 21:39:39 +0000 (17:39 -0400)
gtk_window_set_mnemonics_visible() will try to g_source_remove() it
otherwise, which seems harmless, but conceptually wrong.

https://bugzilla.gnome.org/show_bug.cgi?id=697144

gtk/gtkwindow.c

index e59584558b12f8700ba9062046a10e5734f62413..ff9656e09f664fdf90e519bd69cb5b19722458bb 100644 (file)
@@ -11152,9 +11152,9 @@ set_auto_mnemonics_visible_cb (gpointer data)
 {
   GtkWindow *window = data;
 
-  gtk_window_set_mnemonics_visible (window, TRUE);
+  window->priv->mnemonics_display_timeout_id = 0;
 
-  window->priv->auto_mnemonics_timeout_id = 0;
+  gtk_window_set_mnemonics_visible (window, TRUE);
 
   return FALSE;
 }